[VarDumper] dd() can fallback to a plain text dumper if no suitable Dumper found #58151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful if the consumer cannot handle HTML tags and is not a CLI The current situation is that it is handled by the HtmlDumper but the HTML tags make the result unreadable
pierresh
changed the title
pierresh
changed the title
|
Let's work on #58070 |
|
To my understanding, it would. |
|
There are currently two dumpers. In case of a debugging an JSON API:
Therefore, #58070 will not resolve the problems raised in #49754 and #54772, as both require a plain text dumper. In these issues, the consumer does not support HTML rendering. |
|
Something might make you think otherwise, but CliDumper does output something: plain text dumps. So it fits. |
|
Unless I am mistaken |
|
@pierresh when running in a CGI-based SAPI, the stdout is the HTTP response. |
|
And the output destination is configurable so you can do what you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to this change
dd()fallbacks to a simple plain text dumber if no suitable dumper can be found (discussed also in #58070). So that it could adapt to any situation, even if the consumer did not send any accept headers by default, like Guzzle.I tested and it works well with: