Skip to content

[Form] Fix handling empty data in ValueToDuplicatesTransformer #57920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[Form] Fix handling empty data in ValueToDuplicatesTransformer #57920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Form/Extension/Core/DataTransformer/ValueToDuplicatesTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function reverseTransform($array)
$emptyKeys = [];

foreach ($this->keys as $key) {
if (isset($array[$key]) && '' !== $array[$key] && false !== $array[$key] && [] !== $array[$key]) {
if (isset($array[$key]) && false !== $array[$key] && [] !== $array[$key]) {
if ($array[$key] !== $result) {
throw new TransformationFailedException('All values in the array should be the same.');
}
Expand Down
2 changes: 1 addition & 1 deletion .../Component/Form/Tests/Extension/Core/DataTransformer/ValueToDuplicatesTransformerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function testReverseTransformCompletelyEmpty()
'c' => '',
];

$this->assertNull($this->transformer->reverseTransform($input));
$this->assertSame('', $this->transformer->reverseTransform($input));
}

public function testReverseTransformCompletelyNull()
Expand Down
31 changes: 31 additions & 0 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/RepeatedTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace Symfony\Component\Form\Tests\Extension\Core\Type;

use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\Tests\Fixtures\NotMappedType;
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
Expand Down Expand Up @@ -191,6 +192,36 @@ public function testSetOptionsPerChildAndOverwrite()
$this->assertTrue($form['second']->isRequired());
}

/**
* @dataProvider emptyDataProvider
*/
public function testSubmitNullForTextTypeWithEmptyDataOptionSetToEmptyString($emptyData, $submittedData, $expected)
{
$form = $this->factory->create(static::TESTED_TYPE, null, [
'type' => TextType::class,
'options' => [
'empty_data' => $emptyData,
]
]);
$form->submit($submittedData);

$this->assertSame($expected, $form->getData());
}

public static function emptyDataProvider()
{
yield ['', null, ''];
yield ['', ['first' => null, 'second' => null], ''];
yield ['', ['first' => '', 'second' => null], ''];
yield ['', ['first' => null, 'second' => ''], ''];
yield ['', ['first' => '', 'second' => ''], ''];
yield [null, null, null];
yield [null, ['first' => null, 'second' => null], null];
yield [null, ['first' => '', 'second' => null], null];
yield [null, ['first' => null, 'second' => ''], null];
yield [null, ['first' => '', 'second' => ''], null];
}

public function testSubmitUnequal()
{
$input = ['first' => 'foo', 'second' => 'bar'];
Expand Down