Skip to content

[Process] Fix ProcessTest - testIgnoringSignal for local #57767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[Process] Fix ProcessTest - testIgnoringSignal for local #57767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/Process/Tests/ProcessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,7 @@ public function testIgnoringSignal()
$this->markTestSkipped('pnctl extension is required.');
}

$process = $this->getProcess('sleep 10');
$process = $this->getProcess(['sleep', '10']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change line 1688 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test works without changing it so... no I guess

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this might be true the comment on the test states that it acts as a prove that the previous test tests what it claims to do. Thus the only difference should be the missing setIgnoredSignals() call IMO to keep them as similar as possible.

$process->setIgnoredSignals([\SIGTERM]);

$process->start();
Expand All @@ -1685,7 +1685,7 @@ public function testNotIgnoringSignal()
$this->markTestSkipped('pnctl extension is required.');
}

$process = $this->getProcess('sleep 10');
$process = $this->getProcess(['sleep', '10']);

$process->start();
$process->stop(timeout: 0.2);
Expand Down
Loading