[Mime] Tweak an exception to be more descriptive #57295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Jun 3, 2024
fabpot
commented
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #54162 |
| License | MIT |
|
Fabien, I still suggest adding a code comment referencing the RFC 2392 (maybe also RFC 822) so that devs know why the restriction is in place. Maybe simple above the exception would do. |
I've not added the reference to the spec as we're not doing it anywhere else in the code base. Having it only for this very specific error message would be weird. |
|
It may be a good time to start, you know 😉 In this case, it is exactly the reason to document - a very specific case and a restriction that does not seem to make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.