[Clock] Add attributes to support PHPUnit 10 + 11 #54129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
PHPUnit 11 will complain with the following deprecation: ``` Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead. ``` If we add the attribute too, it stops complaining. So this most be a way to support PHPUnit 11 and older versions.
|
@carsonbot I updated the base branch. |
stof
approved these changes
Mar 1, 2024
|
@stof Seems that Carson is stuck, can you update it to 6.4 milestone? |
derrabus
approved these changes
Mar 1, 2024
|
Thank you @ruudk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading to PHPUnit 11 I noticed the following deprecation:
If we add the attribute too, it stops complaining. So this most be a way to support PHPUnit 11 and older versions.