[Form] Throw error if the number is too high on moneyTransformer #53948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fan2Shrek
force-pushed
the
fix-high-number-money-type
branch
from
60f35cc to
542f755
Compare
xabbuh
reviewed
Feb 15, 2024
src/Symfony/Component/Form/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
Fan2Shrek
force-pushed
the
fix-high-number-money-type
branch
from
542f755 to
f08777b
Compare
asispts
reviewed
Feb 15, 2024
src/Symfony/Component/Form/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
Fan2Shrek
force-pushed
the
fix-high-number-money-type
branch
from
f08777b to
9af694b
Compare
xabbuh
reviewed
Feb 15, 2024
src/Symfony/Component/Form/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
Fan2Shrek
force-pushed
the
fix-high-number-money-type
branch
from
9af694b to
27002c2
Compare
xabbuh
approved these changes
Feb 17, 2024
carsonbot
changed the title
welcoMattic
approved these changes
Feb 19, 2024
fabpot
approved these changes
Feb 23, 2024
|
Thank you @Fan2Shrek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MoneyTypedoes not handle high numbers when using'model_type' => 'integerthis leads to unexpected results :Inputing for instance
111111111111111110,00gets cast back to9223372036854775807.I have added a verification with
\PHP_INT_MAXto throw an error in such caseI'm not sure if this is the best approach.