Skip to content

Add .github/sync-translations.php #53421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 4, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

That's the script I used in #53404

With current branch numbers as example: when adding a new message to translate on 7.1, we would ask the author to add it to the "en.xlf" file on 5.4, to run this script, and only then to send the PR on 5.4
This would ensure new messages are duplicated in all languages.

We could also run chatgpt on that PR to pre-fill all translations, building on #53417

@carsonbot carsonbot added this to the 5.4 milestone Jan 4, 2024
@stof
Copy link
Member

stof commented Jan 4, 2024

The file name looks weird as this script is not really checking translations but adding missing untranslated messages.

@nicolas-grekas nicolas-grekas changed the title Add .github/check-translations.php Add .github/sync-translations.php Jan 5, 2024
@nicolas-grekas
Copy link
Member Author

Script renamed to sync-translations.php
I also added a comment to explain how it should be used when adding a new message to translate.

@fabpot
Copy link
Member

fabpot commented Jan 6, 2024

Thank you @nicolas-grekas.

@fabpot fabpot merged commit b68e8a5 into symfony:5.4 Jan 6, 2024
@nicolas-grekas nicolas-grekas deleted the tr-check branch January 7, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants