Skip to content

[Form] Adding more @var PHPDoc's to silence psalm #53349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ThomasLandauer
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes (kind of)
New feature? no
Deprecations? no
Issues none
License MIT

... as announced in #52861 (comment)

@@ -62,6 +63,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)

if ('single_text' === $options['widget']) {
$builder->addEventListener(FormEvents::PRE_SUBMIT, static function (FormEvent $e) use ($options) {
/** @var PreSubmitEvent $event */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this method, $event is being used as argument of anonymous functions.
Shouldn't we update the type declaration for these arguments instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolas-grekas
Copy link
Member

Thank you @ThomasLandauer.

@nicolas-grekas nicolas-grekas merged commit 014bfac into symfony:6.4 Jan 2, 2024
@ThomasLandauer ThomasLandauer deleted the patch-3 branch January 2, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants