[Filesystem] missing readlink breaking FilesystemTest class on Windows #5234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Another solution may be (need to test it) to add Regards, |
…s (one line of code change)
fabpot
added a commit
that referenced
this pull request
Aug 21, 2012
Commits ------- 47b8538 [Filesystem] missing realpath breaking FilesystemTest class on Windows (one line of code change) Discussion ---------- [Filesystem] missing readlink breaking FilesystemTest class on Windows Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #5233 Todo: License of the code: MIT Documentation PR: fix for windows plateform $file == 'C:\Users\USERNA~1\...' before touch $file == 'C:\Users\Username\... after the touch and readlink so it can pass following assertEquals --------------------------------------------------------------------------- by bdmu at 2012-08-13T05:35:07Z Hello, Another solution may be (need to test it) to add $this->workspace = realpath($this->workspace); line 36, after the mkdir($this->workspace, 0777, true); in the setup method Regards, Christophe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5233
Todo:
License of the code: MIT
Documentation PR:
fix for windows plateform
$file == 'C:\Users\USERNA~1...' before touch
$file == 'C:\Users\Username... after the touch and readlink so it can pass following assertEquals