Skip to content

[AssetMapper] Mark component as non experimental #51247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Symfony/Component/AssetMapper/AssetDependency.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

/**
* Represents a dependency that a MappedAsset has.
*
* @experimental
*/
final class AssetDependency
{
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/AssetMapper/AssetMapper.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
/**
* Finds and returns assets in the pipeline.
*
* @experimental
*
* @final
*/
class AssetMapper implements AssetMapperInterface
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/AssetMapper/AssetMapperCompiler.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
/**
* Runs a chain of compiles intended to adjust the source of assets.
*
* @experimental
*
* @final
*/
class AssetMapperCompiler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
/**
* Functions like a controller that returns assets from the asset mapper.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
final class AssetMapperDevServerSubscriber implements EventSubscriberInterface
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/AssetMapper/AssetMapperInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
/**
* Finds and returns assets in the pipeline.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
interface AssetMapperInterface
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/AssetMapper/AssetMapperRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
/**
* Finds assets in the asset mapper.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*
* @final
Expand Down
5 changes: 5 additions & 0 deletions src/Symfony/Component/AssetMapper/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGELOG
=========

6.4
---

* Mark the component as non experimental

6.3
---

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
*
* This command is intended to be used during deployment.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
#[AsCommand(name: 'asset-map:compile', description: 'Compiles all mapped assets and writes them to the final public output directory.')]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
/**
* Outputs all the assets in the asset mapper.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
#[AsCommand(name: 'debug:asset-map', description: 'Outputs all mapped assets.')]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
use Symfony\Component\Console\Output\OutputInterface;

/**
* @experimental
*
* @author Kévin Dunglas <kevin@dunglas.dev>
*/
#[AsCommand(name: 'importmap:export', description: 'Exports the importmap JSON')]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
use Symfony\Component\Console\Style\SymfonyStyle;

/**
* @experimental
*
* @author Kévin Dunglas <kevin@dunglas.dev>
*/
#[AsCommand(name: 'importmap:remove', description: 'Removes JavaScript packages')]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
use Symfony\Component\Console\Style\SymfonyStyle;

/**
* @experimental
*
* @author Kévin Dunglas <kevin@dunglas.dev>
*/
#[AsCommand(name: 'importmap:require', description: 'Requires JavaScript packages')]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
use Symfony\Component\Console\Style\SymfonyStyle;

/**
* @experimental
*
* @author Kévin Dunglas <kevin@dunglas.dev>
*/
#[AsCommand(name: 'importmap:update', description: 'Updates all JavaScript packages to their latest versions')]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
/**
* An asset compiler is responsible for applying any changes to the contents of an asset.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
interface AssetCompilerInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
/**
* Helps resolve "../" and "./" in paths.
*
* @experimental
*
* @internal
*/
trait AssetCompilerPathResolverTrait
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
* Resolves url() paths in CSS files.
*
* Originally sourced from https://github.com/rails/propshaft/blob/main/lib/propshaft/compilers/css_asset_urls.rb
*
* @experimental
*/
final class CssAssetUrlCompiler implements AssetCompilerInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
/**
* Resolves import paths in JS files.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
final class JavaScriptImportPathCompiler implements AssetCompilerInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
* Rewrites already-existing source map URLs to their final digested path.
*
* Originally sourced from https://github.com/rails/propshaft/blob/main/lib/propshaft/compilers/source_mapping_urls.rb
*
* @experimental
*/
final class SourceMappingUrlsCompiler implements AssetCompilerInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
/**
* Represents an item that should be in the importmap.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
final class ImportMapEntry
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
use Symfony\Component\VarExporter\VarExporter;

/**
* @experimental
*
* @author Kévin Dunglas <kevin@dunglas.dev>
* @author Ryan Weaver <ryan@symfonycasts.com>
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
namespace Symfony\Component\AssetMapper\ImportMap;

/**
* @experimental
*
* @author Kévin Dunglas <kevin@dunglas.dev>
* @author Ryan Weaver <ryan@symfonycasts.com>
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
/**
* Represents a package that should be installed or updated.
*
* @experimental
*
* @author Kévin Dunglas <kevin@dunglas.dev>
*/
final class PackageRequireOptions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
use Symfony\Contracts\HttpClient\Exception\HttpExceptionInterface;
use Symfony\Contracts\HttpClient\HttpClientInterface;

/**
* @experimental
*/
final class JsDelivrEsmResolver implements PackageResolverInterface
{
public const URL_PATTERN_VERSION = 'https://data.jsdelivr.com/v1/packages/npm/%s/resolved?specifier=%s';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
use Symfony\Component\HttpClient\HttpClient;
use Symfony\Contracts\HttpClient\HttpClientInterface;

/**
* @experimental
*/
final class JspmResolver implements PackageResolverInterface
{
public const BASE_URI = 'https://api.jspm.io/';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@

use Psr\Container\ContainerInterface;

/**
* @experimental
*/
final class PackageResolver implements PackageResolverInterface
{
public function __construct(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@

use Symfony\Component\AssetMapper\ImportMap\PackageRequireOptions;

/**
* @experimental
*/
interface PackageResolverInterface
{
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@

use Symfony\Component\AssetMapper\ImportMap\PackageRequireOptions;

/**
* @experimental
*/
final class ResolvedImportMapPackage
{
public function __construct(
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/AssetMapper/MappedAsset.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
/**
* Represents a single asset in the asset mapper system.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
final class MappedAsset
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/AssetMapper/MapperAwareAssetPackage.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
/**
* Decorates asset packages to support resolving assets from the asset mapper.
*
* @experimental
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*/
final class MapperAwareAssetPackage implements PackageInterface
Expand Down
5 changes: 0 additions & 5 deletions src/Symfony/Component/AssetMapper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ then moved to a public directory with digested (i.e. versioned) filenames. It
also allows you to dump an [importmap](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script/type/importmap)
to allow writing modern JavaScript without a build system.

**This Component is experimental**.
[Experimental features](https://symfony.com/doc/current/contributing/code/experimental.html)
are not covered by Symfony's
[Backward Compatibility Promise](https://symfony.com/doc/current/contributing/code/bc.html).

Resources
---------

Expand Down