Skip to content

[Cache] Fix compat with ext-redis v6 #51133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jul 27, 2023

Q A
Branch? 7.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

WIP, looking to fix the failures on appveyor.

Redis::scan() deprecations need phpredis/phpredis#2363

@nicolas-grekas
Copy link
Member Author

There is still work to do to support ext-redis 6. Many failures on appveyor are related to this incomplete support. #51136 fixes the CI at least.
Closing as I won't work on this in the short term. Anyone, please take over if you're up to :) 🙏

@nicolas-grekas nicolas-grekas deleted the cache-redis6 branch July 27, 2023 16:26
@faizanakram99
Copy link
Contributor

faizanakram99 commented Sep 12, 2023

We stumbled upon this today, the server is set to auto-update minor versions and the newest version has redis 6 installed and deployments have been failing since, couldn't figure it out unless i checked the prod logs to see signature mismatch between the proxy class and the actual \Redis class.

Can this be specified in composer.json somehow, it is causing sf to error out with redis 6 (with lazy services which isn't uncommon to avoid creating connection with Redis server)

@ruudk
Copy link
Contributor

ruudk commented Sep 28, 2023

@nicolas-grekas Just came across this PR after opening this issue:

Would it be possible to give this another shot?

There might be more people experiencing this as Redis 6 is now the default when you do pecl install redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants