Skip to content

[DoctrineBridge] add missing UPGRADE notes for #50689 and update tests #50699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
+11 −4
Merged

[DoctrineBridge] add missing UPGRADE notes for #50689 and update tests #50699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions UPGRADE-6.3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
UPGRADE FROM 6.2 to 6.3
=======================

Cache
-----

* `DoctrineDbalAdapter` now takes an optional `$isSameDatabase` parameter

Console
-------

Expand All @@ -22,6 +27,8 @@ DoctrineBridge
* Deprecate `DoctrineDbalCacheAdapterSchemaSubscriber` in favor of `DoctrineDbalCacheAdapterSchemaListener`
* Deprecate `MessengerTransportDoctrineSchemaSubscriber` in favor of `MessengerTransportDoctrineSchemaListener`
* Deprecate `RememberMeTokenProviderDoctrineSchemaSubscriber` in favor of `RememberMeTokenProviderDoctrineSchemaListener`
* `DoctrineTransport` now takes an optional `$isSameDatabase` parameter
* `DoctrineTokenProvider` now takes an optional `$isSameDatabase` parameter

Form
----
Expand Down
2 changes: 1 addition & 1 deletion ...mfony/Bridge/Doctrine/Tests/SchemaListener/DoctrineDbalCacheAdapterSchemaListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function testPostGenerateSchema()
$dbalAdapter = $this->createMock(DoctrineDbalAdapter::class);
$dbalAdapter->expects($this->once())
->method('configureSchema')
->with($schema, $dbalConnection);
->with($schema, $dbalConnection, fn () => true);

$subscriber = new DoctrineDbalCacheAdapterSchemaListener([$dbalAdapter]);
$subscriber->postGenerateSchema($event);
Expand Down
2 changes: 1 addition & 1 deletion ...ony/Bridge/Doctrine/Tests/SchemaListener/MessengerTransportDoctrineSchemaListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function testPostGenerateSchema()
$doctrineTransport = $this->createMock(DoctrineTransport::class);
$doctrineTransport->expects($this->once())
->method('configureSchema')
->with($schema, $dbalConnection);
->with($schema, $dbalConnection, fn () => true);
$otherTransport = $this->createMock(TransportInterface::class);
$otherTransport->expects($this->never())
->method($this->anything());
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/DoctrineTransportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ public function testConfigureSchema()

$connection->expects($this->once())
->method('configureSchema')
->with($schema, $dbalConnection);
->with($schema, $dbalConnection, static fn () => true);

$transport->configureSchema($schema, $dbalConnection);
$transport->configureSchema($schema, $dbalConnection, static fn () => true);
}

private function getTransport(SerializerInterface $serializer = null, Connection $connection = null): DoctrineTransport
Expand Down