[AssetMapper] Adding "path" option to importmap:require #50363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
May 19, 2023
nicolas-grekas
force-pushed
the
import-map-require-path
branch
from
b655ab7 to
a3a5472
Compare
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathoption was added by @dunglas - it was always intended to be there. I forgot about it and (mostly) failed to add it. Now I've found a use-case for it when installing UX bundles (i.e. call the command to update the user's importmap with a pointer to an asset inside of the bundle).Thanks!