Skip to content

[HttpClient] Improve MockHttpClient exception message #50062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Apr 19, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets #49874 (comment)
License MIT
Doc PR -

When using MockHttpClient, if there are more requests done on the client than the passed available responses, the exception message is misleading.

Targeting 5.4 since it only changes the exception message 😅

@nicolas-grekas
Copy link
Member

This is not a bugfix, that's for 6.3 :)

@nicolas-grekas nicolas-grekas modified the milestones: 5.4, 6.3 Apr 19, 2023
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 6.3 April 19, 2023 17:08
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit d5423db into symfony:6.3 Apr 19, 2023
@fancyweb fancyweb deleted the http-client/minor-exception-msg branch April 20, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants