[Translation] Extract constraint class names instead of relying on service declaration #49785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… service declaration
welcoMattic
reviewed
Mar 24, 2023
There was a problem hiding this comment.
This approach is better than the first one, thank you @nfragnet
src/Symfony/Component/Translation/DependencyInjection/TranslatorPass.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathieu Santostefano <msantostefano@protonmail.com>
|
Regarding the tests: any idea how to get rid of deprecation notices making tests fail? Regarding the private method: should it belong elsewhere or do we keep it as it is? Following the discussion here, question asked by @MatTheCat
We can either:
Any other suggestion is welcome. |
welcoMattic
changed the title
|
I have another proposal in #49850. It would need some adjustments to work for 5.4 + some tests. Would you be up to have a look and borrow from there? |
|
Closing in favor of #49850, thanks for raising this! |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 30, 2023
…ts (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [FrameworkBundle] Fix auto-discovering validator constraints | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #49397 | License | MIT | Doc PR | - Alternative to #49785 Note that this kind of container-assisted auto-discovery of non-service classes looks like an interesting pattern for many other subsystems. /cc `@symfony`/mergers `@mtarld` Commits ------- f60218c [FrameworkBundle] Fix auto-discovering validator constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to this one involving a fix translator side.
See it as a discussion support first, more than a definitive proposal.
Instead of relying on service declaration to inject the constraint names to the ConstraintVisitor, we extract them from files and return all class names of classes extending Constraint.
The private method looks like the one we can find in the
DebugCommandand I'm not really sure it has its place directly in the TranslatorPass but this is a first draft and I hope someone can lead me in the right direction to move stuff at the right place.Contrary to my first PR this solution excludes userland constraints. It also exclude constraints from other places than
Symfony/Component/Validator/Constraintsdirectory (likeUniqueEntityfor example).To include them all, we would probably need to:
Userland constraint would be included at the condition of being declared as services.