Register and tag validators in container #49779
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| 'alias' => IsbnValidator::class, | ||
| ]) | ||
|
|
||
| ->set('validator.is_false', IsFalseValidator::class) |
There was a problem hiding this comment.
Are we sure to want to maintain this big list of services? Maybe the fix should be on the translator component since this is the only issue we founded due to not declared constraints?
There was a problem hiding this comment.
I agree with that, this PR is a glimpse of the involvements of a solution going in the way of the original feature taking the postulate that validators were all services
There was a problem hiding this comment.
I’m not sure since the issue is proof that validator.constraint_validator is unreliable. If a fix is applied to the translator component I think this tag would have to be removed.
There was a problem hiding this comment.
Alternative solution in the translator component available here
There was a problem hiding this comment.
Yeah #49785 feels better indeed; it’s not that validator.constraint_validator is unreliable, it’s just that unregistered validators cannot be tagged. But would it be possible to still consider it in TranslatorPass to take userland validators into account?
There was a problem hiding this comment.
Answering the question here and closing this PR.
This PR register validators related to a constraints having violation messages as services in container and tag them so the
TranslatorPasstake them into account when extracting constraint messages in attributes.This PR is a first draft with the solution suggested by @MatTheCat in the related ticket.
It will also extract userland constraint messages if validators are declared as service.