Skip to content

[Notifier] fix tests #49437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,31 +21,31 @@ public function createFactory(): BandwidthTransportFactory
return new BandwidthTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield ['bandwidth://host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority', 'bandwidth://username:password@host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority'];
yield ['bandwidth://host.test?from=0611223344&account_id=account_id&application_id=application_id', 'bandwidth://username:password@host.test?from=0611223344&account_id=account_id&application_id=application_id'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing password' => ['bandwidth://username@default?account_id=account_id&application_id=application_id&priority=priority'];
}

public function missingRequiredOptionProvider(): iterable
public static function missingRequiredOptionProvider(): iterable
{
yield 'missing option: from' => ['bandwidth://username:password@default?account_id=account_id&application_id=application_id&priority=priority'];
yield 'missing option: account_id' => ['bandwidth://username:password@default?from=0611223344&application_id=application_id&priority=priority'];
yield 'missing option: application_id' => ['bandwidth://username:password@default?from=0611223344&account_id=account_id&priority=priority'];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'bandwidth://username:password@default?from=0611223344&account_id=account_id&application_id=application_id&priority=priority'];
yield [false, 'somethingElse://username:password@default?from=0611223344&account_id=account_id&application_id=application_id&priority=priority'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://username:password@default?from=0611223344&account_id=account_id&application_id=application_id&priority=priority'];
yield ['somethingElse://username:password@default?account_id=account_id&application_id=application_id&priority=priority']; // missing "from" option
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function createFactory(): IsendproTransportFactory
return new IsendproTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield [
'isendpro://host.test?no_stop=0&sandbox=0',
Expand Down Expand Up @@ -54,23 +54,23 @@ public function createProvider(): iterable
];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'isendpro://account_key_id@host?from=FROM'];
yield [false, 'somethingElse://account_key_id@default'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing credentials' => ['isendpro://host?from=FROM'];
}

public function missingRequiredOptionProvider(): iterable
public static function missingRequiredOptionProvider(): iterable
{
yield 'missing option: account_key_id' => ['isendpro://default'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://account_key_id@default'];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,26 @@ public function createFactory(): LineNotifyTransportFactory
return new LineNotifyTransportFactory();
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'linenotify://host'];
yield [false, 'somethingElse://host'];
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield [
'linenotify://host.test',
'linenotify://token@host.test',
];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing token' => ['linenotify://host.test'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://token@host'];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function createFactory(): MastodonTransportFactory
return new MastodonTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield [
'mastodon://host.test',
Expand All @@ -47,18 +47,18 @@ public function createProvider(): iterable
];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'mastodon://token@host'];
yield [false, 'somethingElse://token@host'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing token' => ['mastodon://host.test'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://token@host'];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function createFactory(): PagerDutyTransportFactory
return new PagerDutyTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield [
'pagerduty://subdomain.pagerduty.com',
Expand All @@ -30,19 +30,19 @@ public function createProvider(): iterable
];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'pagerduty://host'];
yield [false, 'somethingElse://host'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing token' => ['pagerduty://@host'];
yield 'wrong host' => ['pagerduty://token@host.com'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://token@host'];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,28 @@ public function createFactory(): PlivoTransportFactory
return new PlivoTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield ['plivo://host.test?from=0611223344', 'plivo://authId:authToken@host.test?from=0611223344'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing auth token' => ['plivo://authId@default?from=FROM'];
}

public function missingRequiredOptionProvider(): iterable
public static function missingRequiredOptionProvider(): iterable
{
yield 'missing option: from' => ['plivo://authId:authToken@default'];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'plivo://authId:authToken@default?from=0611223344'];
yield [false, 'somethingElse://authId:authToken@default?from=0611223344'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://authId:authToken@default?from=0611223344'];
yield ['somethingElse://authId:authToken@default']; // missing "from" option
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,28 @@ public function createFactory(): RingCentralTransportFactory
return new RingCentralTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield ['ringcentral://host.test?from=0611223344', 'ringcentral://apiToken@host.test?from=0611223344'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing auth token' => ['ringcentral://@default?from=FROM'];
}

public function missingRequiredOptionProvider(): iterable
public static function missingRequiredOptionProvider(): iterable
{
yield 'missing option: from' => ['ringcentral://apiToken@default'];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'ringcentral://apiToken@default?from=0611223344'];
yield [false, 'somethingElse://apiToken@default?from=0611223344'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://apiToken@default?from=0611223344'];
yield ['somethingElse://apiToken@default']; // missing "from" option
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ public static function incompleteDsnProvider(): iterable
yield 'missing token' => ['smsapi://host.test?from=testFrom'];
}

public static function missingRequiredOptionProvider(): iterable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #49261

{
yield 'missing option: from' => ['smsapi://token@host'];
}

public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://token@host?from=testFrom'];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,29 +21,29 @@ public function createFactory(): TermiiTransportFactory
return new TermiiTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield ['termii://host.test?from=0611223344&channel=generic', 'termii://apiKey@host.test?from=0611223344&channel=generic'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing auth ID' => ['termii://@default?from=FROM'];
}

public function missingRequiredOptionProvider(): iterable
public static function missingRequiredOptionProvider(): iterable
{
yield 'missing option: from' => ['termii://apiKey@default?channel=generic'];
yield 'missing option: channel' => ['termii://apiKey@default?from=0611223344'];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'termii://apiKey@default?from=0611223344&channel=generic'];
yield [false, 'somethingElse://apiKey@default?from=0611223344&channel=generic'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://apiKey@default?from=0611223344&channel=generic'];
yield ['somethingElse://apiKey@default']; // missing "from" option
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,23 @@ public function createFactory(): TwitterTransportFactory
return new TwitterTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield ['twitter://host.test', 'twitter://A:B:C:D@host.test'];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'twitter://default'];
yield [false, 'somethingElse://default'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://default'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield ['twitter://A:B@default', 'Invalid "twitter://default" notifier DSN: Access Token is missing'];
}
Expand Down