[Form] Improved performance of ChoiceType and EntityType #4881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Jul 12, 2012
Commits ------- a924dab [OptionsResolver] Made the OptionsResolver clonable 70307e5 [Form] Improved EntityType performance by caching the EntityChoiceList 8298d8c [Form] Improved ChoiceType performance by caching ChoiceList objects Discussion ---------- [Form] Improved performance of ChoiceType and EntityType Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: -
| @@ -59,17 +65,34 @@ public function setDefaultOptions(OptionsResolverInterface $resolver) | |||
| return null; | |||
| }; | |||
|
|
|||
| $choiceList = function (Options $options) use ($registry) { | |||
| $choiceList = function (Options $options) use ($registry, &$choiceListCache, &$time) { | |||
There was a problem hiding this comment.
what is $time here ? it seems undefined and unused
There was a problem hiding this comment.
Fixed already. I was faster than you hehehe ;)
There was a problem hiding this comment.
@bschussek it is not fixed: https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L67
It seems like @fabpot was faster to merge :)
There was a problem hiding this comment.
It's in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -