Skip to content

[Console] skip a test if the signal to be sent is not available #48325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2022
Merged

[Console] skip a test if the signal to be sent is not available #48325

merged 1 commit into from
Nov 25, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 25, 2022

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh requested a review from chalasr as a code owner November 25, 2022 11:04
@carsonbot carsonbot added this to the 5.4 milestone Nov 25, 2022
@xabbuh
Copy link
Member Author

xabbuh commented Nov 25, 2022

FTR: https://ci.appveyor.com/project/fabpot/symfony/builds/45488468#L1657 (this is how it fails without the change)

@fabpot
Copy link
Member

fabpot commented Nov 25, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit 1313c45 into symfony:5.4 Nov 25, 2022
@xabbuh xabbuh deleted the pr-45333 branch November 25, 2022 11:39
@xabbuh xabbuh mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @stof @carsonbot