Skip to content

[Mailer] Add a way to change the Bus transport dynamically #47190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
use Symfony\Component\Mailer\Bridge\Sendgrid\Transport\SendgridTransportFactory;
use Symfony\Component\Mailer\Bridge\Sendinblue\Transport\SendinblueTransportFactory;
use Symfony\Component\Mailer\Command\MailerTestCommand;
use Symfony\Component\Mailer\EventListener\MessengerTransportListener;
use Symfony\Component\Mailer\Mailer;
use Symfony\Component\Mercure\HubRegistry;
use Symfony\Component\Messenger\Attribute\AsMessageHandler;
Expand Down Expand Up @@ -2486,6 +2487,10 @@ private function registerMailerConfiguration(array $config, ContainerBuilder $co
} else {
$container->removeDefinition('mailer.message_listener');
}

if (!class_exists(MessengerTransportListener::class)) {
$container->removeDefinition('mailer.messenger_transport_listener');
}
}

private function registerNotifierConfiguration(array $config, ContainerBuilder $container, PhpFileLoader $loader)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use Symfony\Component\Mailer\EventListener\EnvelopeListener;
use Symfony\Component\Mailer\EventListener\MessageListener;
use Symfony\Component\Mailer\EventListener\MessageLoggerListener;
use Symfony\Component\Mailer\EventListener\MessengerTransportListener;
use Symfony\Component\Mailer\Mailer;
use Symfony\Component\Mailer\MailerInterface;
use Symfony\Component\Mailer\Messenger\MessageHandler;
Expand Down Expand Up @@ -74,6 +75,9 @@
->tag('kernel.event_subscriber')
->tag('kernel.reset', ['method' => 'reset'])

->set('mailer.messenger_transport_listener', MessengerTransportListener::class)
->tag('kernel.event_subscriber')

->set('console.command.mailer_test', MailerTestCommand::class)
->args([
service('mailer.transports'),
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"symfony/html-sanitizer": "^6.1",
"symfony/http-client": "^5.4|^6.0",
"symfony/lock": "^5.4|^6.0",
"symfony/mailer": "^5.4|^6.0",
"symfony/mailer": "^6.2",
"symfony/messenger": "^6.1",
"symfony/mime": "^5.4|^6.0",
"symfony/notifier": "^5.4|^6.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Mailer\EventListener;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Mailer\Event\QueuingMessageEvent;
use Symfony\Component\Messenger\Stamp\TransportNamesStamp;
use Symfony\Component\Mime\Message;

/**
* Allows messages to be sent to specific Messenger transports via the "X-Bus-Transport" MIME header.
*
* @author Fabien Potencier <fabien@symfony.com>
*/
final class MessengerTransportListener implements EventSubscriberInterface
{
public function onMessage(QueuingMessageEvent $event): void
{
$message = $event->getMessage();
if (!$message instanceof Message || !$message->getHeaders()->has('X-Bus-Transport')) {
return;
}

$names = $message->getHeaders()->get('X-Bus-Transport')->getBody();
$names = array_map('trim', explode(',', $names));
$event->addStamp(new TransportNamesStamp($names));
$message->getHeaders()->remove('X-Bus-Transport');
}

public static function getSubscribedEvents(): array
{
return [
QueuingMessageEvent::class => 'onMessage',
];
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Mailer\Tests\EventListener;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Mailer\Envelope;
use Symfony\Component\Mailer\Event\QueuingMessageEvent;
use Symfony\Component\Mailer\EventListener\MessengerTransportListener;
use Symfony\Component\Messenger\Stamp\TransportNamesStamp;
use Symfony\Component\Mime\Address;
use Symfony\Component\Mime\Header\Headers;
use Symfony\Component\Mime\Message;

class MessengerTransportListenerTest extends TestCase
{
public function testNoMessengerTransportStampsByDefault()
{
$l = new MessengerTransportListener();
$envelope = new Envelope(new Address('sender@example.com'), [new Address('recipient@example.com')]);
$message = new Message(new Headers());
$event = new QueuingMessageEvent($message, $envelope, 'smtp');
$l->onMessage($event);
$this->assertEmpty($event->getStamps());
}

public function testMessengerTransportStampViaHeader()
{
$l = new MessengerTransportListener();
$envelope = new Envelope(new Address('sender@example.com'), [new Address('recipient@example.com')]);
$headers = (new Headers())->addTextHeader('X-Bus-Transport', 'async');
$message = new Message($headers);
$event = new QueuingMessageEvent($message, $envelope, 'smtp');
$l->onMessage($event);
$this->assertCount(1, $event->getStamps());
/* @var TransportNamesStamp $stamp */
$this->assertInstanceOf(TransportNamesStamp::class, $stamp = $event->getStamps()[0]);
$this->assertSame(['async'], $stamp->getTransportNames());
$this->assertTrue($headers->has('X-Bus-Transport'));
}

public function testMessengerTransportStampsViaHeader()
{
$l = new MessengerTransportListener();
$envelope = new Envelope(new Address('sender@example.com'), [new Address('recipient@example.com')]);
$name = 'söme_very_long_and_weïrd transport name-for-messenger!';
$headers = (new Headers())->addTextHeader('X-Bus-Transport', ' async , async1,'.$name);
$message = new Message($headers);
$event = new QueuingMessageEvent($message, $envelope, 'smtp');
$l->onMessage($event);
$this->assertCount(1, $event->getStamps());
/* @var TransportNamesStamp $stamp */
$this->assertInstanceOf(TransportNamesStamp::class, $stamp = $event->getStamps()[0]);
$this->assertSame(['async', 'async1', $name], $stamp->getTransportNames());
}
}
5 changes: 3 additions & 2 deletions src/Symfony/Component/Mailer/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@
"require-dev": {
"symfony/console": "^5.4|^6.0",
"symfony/http-client-contracts": "^1.1|^2|^3",
"symfony/messenger": "^5.4|^6.0"
"symfony/messenger": "^6.2"
},
"conflict": {
"symfony/http-kernel": "<5.4"
"symfony/http-kernel": "<5.4",
"symfony/messenger": "<6.2"
},
"autoload": {
"psr-4": { "Symfony\\Component\\Mailer\\": "" },
Expand Down