Skip to content

fix query explanation table width restrictions #46750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix query explanation table width restrictions #46750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,7 +1234,10 @@ tr.log-status-silenced {
}
.sql-explain {
overflow-x: auto;
max-width: 920px;
max-width: 888px;
}
.width-full .sql-explain {
max-width: min-content;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we could even use max-width: unset to not restrict the max width, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Javier for taking the time to review my pull request. I'm OK with the suggested change.
Let me know if I should make that change. Not sure about the workflow here since it's my first PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe max-width: fit-content? Unset would make simple explain windows too wide on big screens.

image
as opposed to
image

But it's your call. We could go either way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't reply earlier. Don't worry about this. Now that this is merged, people can test it for real and if there's any issue we'll get reports. So, everything is fine. Thanks!

}
.sql-explain table td, .sql-explain table tr {
word-break: normal;
Expand Down