Skip to content

[Security] Don't allow empty username or empty password #46109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Security] Don't allow empty username or empty password #46109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Symfony/Component/Security/Http/Authenticator/JsonLoginAuthenticator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,8 @@ private function getCredentials(Request $request)
try {
$credentials['username'] = $this->propertyAccessor->getValue($data, $this->options['username_path']);

if (!\is_string($credentials['username'])) {
throw new BadRequestHttpException(sprintf('The key "%s" must be a string.', $this->options['username_path']));
if (!\is_string($credentials['username']) || $credentials['username'] === "") {
throw new BadRequestHttpException(sprintf('The key "%s" must be a non empty string.', $this->options['username_path']));
}

if (\strlen($credentials['username']) > Security::MAX_USERNAME_LENGTH) {
Expand All @@ -184,8 +184,8 @@ private function getCredentials(Request $request)
try {
$credentials['password'] = $this->propertyAccessor->getValue($data, $this->options['password_path']);

if (!\is_string($credentials['password'])) {
throw new BadRequestHttpException(sprintf('The key "%s" must be a string.', $this->options['password_path']));
if (!\is_string($credentials['password']) || $credentials['password'] === "") {
throw new BadRequestHttpException(sprintf('The key "%s" must be a non empty string.', $this->options['password_path']));
}
} catch (AccessException $e) {
throw new BadRequestHttpException(sprintf('The key "%s" must be provided.', $this->options['password_path']), $e);
Expand Down
10 changes: 8 additions & 2 deletions src/Symfony/Component/Security/Http/Tests/Authenticator/JsonLoginAuthenticatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,16 @@ public function provideInvalidAuthenticateData()
yield [$request, 'The key "password" must be provided'];

$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": 1, "password": "foo"}');
yield [$request, 'The key "username" must be a string.'];
yield [$request, 'The key "username" must be a non empty string.'];

$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": "dunglas", "password": 1}');
yield [$request, 'The key "password" must be a string.'];
yield [$request, 'The key "password" must be a non empty string.'];

$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": "", "password": ""}');
yield [$request, 'The key "username" must be a non empty string.'];

$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": "rimas", "password": ""}');
yield [$request, 'The key "password" must be a non empty string.'];

$username = str_repeat('x', Security::MAX_USERNAME_LENGTH + 1);
$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], sprintf('{"username": "%s", "password": 1}', $username));
Expand Down