[Validator] Allow Sequence constraint to be applied onto class as an attribute #44448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidz
force-pushed
the
add-class-target-on-sequence-validator
branch
2 times, most recently
from
f0bdbd3 to
1c317dd
Compare
|
Hey! I think @jschaedl has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
sidz
force-pushed
the
add-class-target-on-sequence-validator
branch
3 times, most recently
from
0d13b84 to
eac5d97
Compare
ogizanagi
reviewed
Dec 14, 2021
derrabus
approved these changes
Dec 14, 2021
sidz
requested review from
chalasr,
dunglas,
jderusse,
lyrixx,
OskarStark,
wouterj,
xabbuh and
yceruto
as code owners
sidz
force-pushed
the
add-class-target-on-sequence-validator
branch
from
d47457b to
31b35de
Compare
nicolas-grekas
force-pushed
the
add-class-target-on-sequence-validator
branch
from
31b35de to
8c1e746
Compare
|
Thank you @sidz. |
xabbuh
reviewed
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to apply
Sequentiallyconstraint as an attribute onto class target.Looks like it was missed on translating annotations to attributes.