Skip to content

[Validator] Allow Sequence constraint to be applied onto class as an attribute #44448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2021
Merged

[Validator] Allow Sequence constraint to be applied onto class as an attribute #44448

merged 1 commit into from
Dec 15, 2021

Conversation

sidz
Copy link
Contributor

@sidz sidz commented Dec 3, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #44531
License MIT
Doc PR N/A

This PR allows to apply Sequentially constraint as an attribute onto class target.

Looks like it was missed on translating annotations to attributes.

image
image

@carsonbot carsonbot added this to the 6.1 milestone Dec 3, 2021
@sidz sidz changed the base branch from 6.1 to 5.4 December 3, 2021 14:55
@carsonbot
Copy link

Hey!

I think @jschaedl has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@derrabus derrabus modified the milestones: 6.1, 5.4 Dec 14, 2021
@nicolas-grekas
Copy link
Member

Thank you @sidz.

@nicolas-grekas nicolas-grekas merged commit 8f591c3 into symfony:5.4 Dec 15, 2021
@sidz sidz deleted the add-class-target-on-sequence-validator branch December 15, 2021 13:31
This was referenced Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants