Skip to content

Fix typo in sponsor name #44351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix typo in sponsor name #44351

merged 1 commit into from
Nov 30, 2021

Conversation

jovobe
Copy link
Contributor

@jovobe jovobe commented Nov 30, 2021

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

This fixes a typo in the name of basecom (sponsor for 6.1).

Signed-off-by: Johan M. von Behren <johan@vonbehren.eu>
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2021

Thank you Johan.

@xabbuh xabbuh merged commit 02b40c0 into symfony:6.1 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants