Skip to content

Fix tests when security-http 5.4 uses security-core 6.0 #42907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix tests when security-http 5.4 uses security-core 6.0 #42907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/Symfony/Component/Security/Http/Tests/Firewall/ContextListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ public function supportsClass($class): bool
}
}

class CustomToken implements TokenInterface
abstract class BaseCustomToken implements TokenInterface
{
private $user;
private $roles;
Expand Down Expand Up @@ -638,11 +638,24 @@ public function hasAttribute(string $name): bool
return false;
}

public function getAttribute(string $name)
public function setAttribute(string $name, $value)
{
}
}

public function setAttribute(string $name, $value)
if (\PHP_VERSION_ID >= 80000) {
class CustomToken extends BaseCustomToken
{
public function getAttribute(string $name): mixed
{
return null;
}
}
} else {
class CustomToken extends BaseCustomToken
{
public function getAttribute(string $name)
{
}
}
}