symfony · nicolas-grekas · Aug 19, 2021 · Aug 12, 2021
@@ -51,7 +51,7 @@ public function __construct(string|array $groups)
     /**
      * @return string[]
      */
-    public function getGroups()
+    public function getGroups(): array
     {
         return $this->groups;
     }

@@ -23,5 +23,5 @@ interface ContextAwareDecoderInterface extends DecoderInterface
      *
      * @param array $context options that decoders have access to
      */
-    public function supportsDecoding(string $format, array $context = []);
+    public function supportsDecoding(string $format, array $context = []): bool;
 }
@@ -23,5 +23,5 @@ interface ContextAwareEncoderInterface extends EncoderInterface
      *
      * @param array $context options that encoders have access to
      */
-    public function supportsEncoding(string $format, array $context = []);
+    public function supportsEncoding(string $format, array $context = []): bool;
 }
@@ -58,7 +58,7 @@ public function __construct(array $defaultContext = [])
     /**
      * {@inheritdoc}
      */
-    public function encode(mixed $data, string $format, array $context = [])
+    public function encode(mixed $data, string $format, array $context = []): string
     {
         $handle = fopen('php://temp,', 'w+');
 
@@ -123,15 +123,15 @@ public function encode(mixed $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsEncoding(string $format)
+    public function supportsEncoding(string $format): bool
     {
         return self::FORMAT === $format;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function decode(string $data, string $format, array $context = [])
+    public function decode(string $data, string $format, array $context = []): mixed
     {
         $handle = fopen('php://temp', 'r+');
         fwrite($handle, $data);
@@ -209,7 +209,7 @@ public function decode(string $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsDecoding(string $format)
+    public function supportsDecoding(string $format): bool
     {
         return self::FORMAT === $format;
     }

@@ -30,18 +30,14 @@ interface DecoderInterface
      * are encouraged to document which formats they support in a non-inherited
      * phpdoc comment.
      *
-     * @return mixed
-     *
      * @throws UnexpectedValueException
      */
-    public function decode(string $data, string $format, array $context = []);
+    public function decode(string $data, string $format, array $context = []): mixed;
 
     /**
      * Checks whether the deserializer can decode from given format.
      *
      * @param string $format Format name
-     *
-     * @return bool
      */
-    public function supportsDecoding(string $format);
+    public function supportsDecoding(string $format): bool;
 }
@@ -25,18 +25,14 @@ interface EncoderInterface
      * @param string $format  Format name
      * @param array  $context Options that normalizers/encoders have access to
      *
-     * @return string
-     *
      * @throws UnexpectedValueException
      */
-    public function encode(mixed $data, string $format, array $context = []);
+    public function encode(mixed $data, string $format, array $context = []): string;
 
     /**
      * Checks whether the serializer can encode to given format.
      *
      * @param string $format Format name
-     *
-     * @return bool
      */
-    public function supportsEncoding(string $format);
+    public function supportsEncoding(string $format): bool;
 }
@@ -66,13 +66,11 @@ public function __construct(array $defaultContext = [])
      * json_decode_options: integer
      *      Specifies additional options as per documentation for json_decode
      *
-     * @return mixed
-     *
      * @throws NotEncodableValueException
      *
      * @see https://php.net/json_decode
      */
-    public function decode(string $data, string $format, array $context = [])
+    public function decode(string $data, string $format, array $context = []): mixed
     {
         $associative = $context[self::ASSOCIATIVE] ?? $this->defaultContext[self::ASSOCIATIVE];
         $recursionDepth = $context[self::RECURSION_DEPTH] ?? $this->defaultContext[self::RECURSION_DEPTH];
@@ -98,7 +96,7 @@ public function decode(string $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsDecoding(string $format)
+    public function supportsDecoding(string $format): bool
     {
         return JsonEncoder::FORMAT === $format;
     }

@@ -34,7 +34,7 @@ public function __construct(array $defaultContext = [])
     /**
      * {@inheritdoc}
      */
-    public function encode(mixed $data, string $format, array $context = [])
+    public function encode(mixed $data, string $format, array $context = []): string
     {
         $options = $context[self::OPTIONS] ?? $this->defaultContext[self::OPTIONS];
 
@@ -58,7 +58,7 @@ public function encode(mixed $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsEncoding(string $format)
+    public function supportsEncoding(string $format): bool
     {
         return JsonEncoder::FORMAT === $format;
     }

@@ -32,31 +32,31 @@ public function __construct(JsonEncode $encodingImpl = null, JsonDecode $decodin
     /**
      * {@inheritdoc}
      */
-    public function encode(mixed $data, string $format, array $context = [])
+    public function encode(mixed $data, string $format, array $context = []): string
     {
         return $this->encodingImpl->encode($data, self::FORMAT, $context);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function decode(string $data, string $format, array $context = [])
+    public function decode(string $data, string $format, array $context = []): mixed
     {
         return $this->decodingImpl->decode($data, self::FORMAT, $context);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function supportsEncoding(string $format)
+    public function supportsEncoding(string $format): bool
     {
         return self::FORMAT === $format;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function supportsDecoding(string $format)
+    public function supportsDecoding(string $format): bool
     {
         return self::FORMAT === $format;
     }

@@ -80,7 +80,7 @@ public function __construct(array $defaultContext = [])
     /**
      * {@inheritdoc}
      */
-    public function encode(mixed $data, string $format, array $context = [])
+    public function encode(mixed $data, string $format, array $context = []): string
     {
         $encoderIgnoredNodeTypes = $context[self::ENCODER_IGNORED_NODE_TYPES] ?? $this->defaultContext[self::ENCODER_IGNORED_NODE_TYPES];
         $ignorePiNode = \in_array(\XML_PI_NODE, $encoderIgnoredNodeTypes, true);
@@ -108,7 +108,7 @@ public function encode(mixed $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function decode(string $data, string $format, array $context = [])
+    public function decode(string $data, string $format, array $context = []): mixed
     {
         if ('' === trim($data)) {
             throw new NotEncodableValueException('Invalid XML data, it can not be empty.');
@@ -175,15 +175,15 @@ public function decode(string $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsEncoding(string $format)
+    public function supportsEncoding(string $format): bool
     {
         return self::FORMAT === $format;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function supportsDecoding(string $format)
+    public function supportsDecoding(string $format): bool
     {
         return self::FORMAT === $format;
     }

@@ -54,7 +54,7 @@ public function __construct(Dumper $dumper = null, Parser $parser = null, array
     /**
      * {@inheritdoc}
      */
-    public function encode(mixed $data, string $format, array $context = [])
+    public function encode(mixed $data, string $format, array $context = []): string
     {
         $context = array_merge($this->defaultContext, $context);
 
@@ -68,15 +68,15 @@ public function encode(mixed $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsEncoding(string $format)
+    public function supportsEncoding(string $format): bool
     {
         return self::FORMAT === $format || self::ALTERNATIVE_FORMAT === $format;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function decode(string $data, string $format, array $context = [])
+    public function decode(string $data, string $format, array $context = []): mixed
     {
         $context = array_merge($this->defaultContext, $context);
 
@@ -86,7 +86,7 @@ public function decode(string $data, string $format, array $context = [])
     /**
      * {@inheritdoc}
      */
-    public function supportsDecoding(string $format)
+    public function supportsDecoding(string $format): bool
     {
         return self::FORMAT === $format || self::ALTERNATIVE_FORMAT === $format;
     }

@@ -31,10 +31,8 @@ public function __construct(array $extraAttributes, \Throwable $previous = null)
 
     /**
      * Get the extra attributes that are not allowed.
-     *
-     * @return array
      */
-    public function getExtraAttributes()
+    public function getExtraAttributes(): array
     {
         return $this->extraAttributes;
     }

@@ -119,7 +119,7 @@ public function setMaxDepth(?int $maxDepth)
     /**
      * {@inheritdoc}
      */
-    public function getMaxDepth()
+    public function getMaxDepth(): ?int
     {
         return $this->maxDepth;
     }
@@ -261,7 +261,7 @@ public function merge(AttributeMetadataInterface $attributeMetadata)
      *
      * @return string[]
      */
-    public function __sleep()
+    public function __sleep(): array
     {
         return ['name', 'groups', 'maxDepth', 'serializedName', 'ignore', 'normalizationContexts', 'denormalizationContexts'];
     }

@@ -46,10 +46,8 @@ public function setMaxDepth(?int $maxDepth);
 
     /**
      * Gets the serialization max depth for this attribute.
-     *
-     * @return int|null
      */
-    public function getMaxDepth();
+    public function getMaxDepth(): ?int;
 
     /**
      * Sets the serialization name for this attribute.

@@ -128,7 +128,7 @@ public function setClassDiscriminatorMapping(ClassDiscriminatorMapping $mapping
      *
      * @return string[]
      */
-    public function __sleep()
+    public function __sleep(): array
     {
         return [
             'name',

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Serializer\Mapping\Factory;
 
 use Psr\Cache\CacheItemPoolInterface;
+use Symfony\Component\Serializer\Mapping\ClassMetadataInterface;
 
 /**
  * Caches metadata using a PSR-6 implementation.
@@ -43,7 +44,7 @@ public function __construct(ClassMetadataFactoryInterface $decorated, CacheItemP
     /**
      * {@inheritdoc}
      */
-    public function getMetadataFor(string|object $value)
+    public function getMetadataFor(string|object $value): ClassMetadataInterface
     {
         $class = $this->getClass($value);
 
@@ -67,7 +68,7 @@ public function getMetadataFor(string|object $value)
     /**
      * {@inheritdoc}
      */
-    public function hasMetadataFor(mixed $value)
+    public function hasMetadataFor(mixed $value): bool
     {
         return $this->decorated->hasMetadataFor($value);
     }

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Serializer\Mapping\Factory;
 
 use Symfony\Component\Serializer\Mapping\ClassMetadata;
+use Symfony\Component\Serializer\Mapping\ClassMetadataInterface;
 use Symfony\Component\Serializer\Mapping\Loader\LoaderInterface;
 
 /**
@@ -38,7 +39,7 @@ public function __construct(LoaderInterface $loader)
     /**
      * {@inheritdoc}
      */
-    public function getMetadataFor(string|object $value)
+    public function getMetadataFor(string|object $value): ClassMetadataInterface
     {
         $class = $this->getClass($value);
 
@@ -67,7 +68,7 @@ public function getMetadataFor(string|object $value)
     /**
      * {@inheritdoc}
      */
-    public function hasMetadataFor(mixed $value)
+    public function hasMetadataFor(mixed $value): bool
     {
         return \is_object($value) || (\is_string($value) && (class_exists($value) || interface_exists($value, false)));
     }

@@ -34,16 +34,12 @@ interface ClassMetadataFactoryInterface
      * {@link \Symfony\Component\Serializer\Mapping\Loader\LoaderInterface::loadClassMetadata()} method for further
      * configuration. At last, the new object is returned.
      *
-     * @return ClassMetadataInterface
-     *
      * @throws InvalidArgumentException
      */
-    public function getMetadataFor(string|object $value);
+    public function getMetadataFor(string|object $value): ClassMetadataInterface;
 
     /**
      * Checks if class has metadata.
-     *
-     * @return bool
      */
-    public function hasMetadataFor(mixed $value);
+    public function hasMetadataFor(mixed $value): bool;
 }
@@ -51,7 +51,7 @@ public function __construct(Reader $reader = null)
     /**
      * {@inheritdoc}
      */
-    public function loadClassMetadata(ClassMetadataInterface $classMetadata)
+    public function loadClassMetadata(ClassMetadataInterface $classMetadata): bool
     {
         $reflectionClass = $classMetadata->getReflectionClass();
         $className = $reflectionClass->name;

@@ -50,7 +50,7 @@ public function __construct(array $loaders)
     /**
      * {@inheritdoc}
      */
-    public function loadClassMetadata(ClassMetadataInterface $metadata)
+    public function loadClassMetadata(ClassMetadataInterface $metadata): bool
     {
         $success = false;
 
@@ -64,7 +64,7 @@ public function loadClassMetadata(ClassMetadataInterface $metadata)
     /**
      * @return LoaderInterface[]
      */
-    public function getLoaders()
+    public function getLoaders(): array
     {
         return $this->loaders;
     }