[Console] SymfonyStyle - add string type to confirm() $question by co… #41987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jul 5, 2021
ogizanagi
approved these changes
Jul 5, 2021
krzysztof-raciniewski
approved these changes
Jul 5, 2021
derrabus
approved these changes
Jul 5, 2021
|
Thank you @TomasVotruba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR retargeted from Symfony 5.4: #41983
Inspired by & follow up to #41946 by @nicolas-grekas
This type is always string, see contract
symfony/src/Symfony/Component/Console/Style/StyleInterface.php
Line 102 in 5010ebd
Also
ConfirmationQuestionrequiresstringstrict type bellowProbably forgotten during adding types everywhere in #32318