Skip to content

[Mime] Fix CSV file mime type guess test for PHP 8.1 #41614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jun 8, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Part of #41552
License MIT
Doc PR N/A

I had the same result as @derrabus on my computer: application/csv. The CI returns text/csv. These two seem possible, although text/csv is described in RFC 7111.

(Oops little typo in title, thanks Alexander for the fix 🙏 )

@alexandre-daubois alexandre-daubois force-pushed the fix-mime-type-csv-test branch from 2412301 to 117cb8f Compare June 8, 2021 11:23
@carsonbot carsonbot changed the title [DependencyInjection] Fix CSV file mime type guess test for PHP 8.1 [Mime] Fix CSV file mime type guess test for PHP 8.1 Jun 8, 2021
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 7445c3e into symfony:4.4 Jun 9, 2021
@alexandre-daubois alexandre-daubois deleted the fix-mime-type-csv-test branch June 9, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants