[WebProfilerBundle] Add simple backoff strategy on 404 #41115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
May 5, 2021
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
carsonbot
changed the title
|
@stof: I have made a new backoff strategy that actually uses the number of request tries. What do you think? The sequence would now be 1, 2, 4, 8, 16 seconds. |
|
I changed from |
nicolas-grekas
approved these changes
May 7, 2021
|
Cool, thank you :) |
|
Thank you @loevgaard. |
|
Nice addition! Is the change regarding "infinite" loading, as suggested in #15670, still viable? I could provide a PR with that, if you think loading without max-retries is an option. |
|
With this PR the user has waited 31 seconds if the the 5th try is executed. I am not sure anybody would wait longer than that, but I could be wrong :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just retrying every second 5 times, this PR implements a very basic backoff strategy where it waits 1, 1, 2, 3, 5 seconds between the respective requests instead which amounts to a total wait of 12 seconds instead of 5.