Skip to content

[Workflow] Deprecate InvalidTokenConfigurationException #40202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2021
Merged

[Workflow] Deprecate InvalidTokenConfigurationException #40202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions UPGRADE-5.3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,8 @@ Uid
---

* Replaced `UuidV1::getTime()`, `UuidV6::getTime()` and `Ulid::getTime()` by `UuidV1::getDateTime()`, `UuidV6::getDateTime()` and `Ulid::getDateTime()`

Workflow
--------

* Deprecate `InvalidTokenConfigurationException`
5 changes: 5 additions & 0 deletions UPGRADE-6.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,11 @@ Validator
->addDefaultDoctrineAnnotationReader();
```

Workflow
--------

* Remove `InvalidTokenConfigurationException`

Yaml
----

Expand Down
5 changes: 5 additions & 0 deletions src/Symfony/Component/Workflow/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGELOG
=========

5.3
---

* Deprecate `InvalidTokenConfigurationException`

5.2.0
-----

Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Workflow/Exception/InvalidTokenConfigurationException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,14 @@

namespace Symfony\Component\Workflow\Exception;

trigger_deprecation('symfony/workflow', '5.3', sprintf('The "%s" class is deprecated.', InvalidTokenConfigurationException::class));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While checking the doc issue for this (symfony/symfony-docs#14987) I found this PR. I think we should always include an alternative in the deprecation messages.

If the developer sees just this message -> "The InvalidTokenConfigurationException class is deprecated." they don't know what to do. OK, it's deprecated but ... is there a new class that replaces it? Is this gone for good without an alternative?

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's gone. This exception is not thrown anymore by symfony.


/**
* Thrown by GuardListener when there is no token set, but guards are placed on a transition.
*
* @author Matt Johnson <matj1985@gmail.com>
*
* @deprecated since Symfony 5.3
*/
class InvalidTokenConfigurationException extends LogicException
{
Expand Down