Skip to content

[FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path" #40138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Because annotations.cache is registered in a quite special way (see #25696), ResolveHotPathPass cannot propagate the container.hot_path tag to it.

Let's add the tag explicitly since this service is always on the hot path anyway.

Spotted with Blackfire.io as usual.

@nicolas-grekas nicolas-grekas merged commit c75687f into symfony:4.4 Feb 10, 2021
@nicolas-grekas nicolas-grekas deleted the fwb-hot-cache branch February 15, 2021 09:27
This was referenced Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants