[Validator] Added range constraint #3893
Conversation
|
@felds Your initial issue could be used by using validation groups (i.e. validate the numeric type before validating the value). So the only problem this is solving is saving some chars. To be complete you should also update the |
|
@vicb do you mean running the validators twice? |
|
I mean using group sequences. |
|
@vicb I didn't know about that (and google isn't helping). How can I learn more about that? |
|
There should be a couple of PR / issues that you can look for in Sf or Sf-doc (#2947 for example). I am not sure if this is already documented... Can you check ? (and if it is not, please create an issue or even better a PR) |
|
And also by looking at the tests |
|
@felds Besides such a constraint already exists (at least in master, not sure about 2.0): the |
|
@vicb AFAIK @bschussek (or anyone else) never had time to write something in the doc about group sequences and he seems to be the only one who know them well enough. I created an issue in the doc: symfony/symfony-docs#1248 |
|
thanks |
When using the Min and Max constraints in combination and a non-numeric value is submitted, both show an "invalid" message at the same time.
Another approach that I can see could be making their type validation optional, ignoring every non-numeric value when asked to, but this would change their current API, and I don't think it's a smart move for something so critical as validation.
This new Constraint works around that by creating a combined min/max constraint without changing their existing API and also simplifying the configuration by reducing the number of annotations needed to perform this validation.