Skip to content

[Notifier] Register NotificationDataCollector and NotificationLoggerListener service #38068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2020
Merged

[Notifier] Register NotificationDataCollector and NotificationLoggerListener service #38068

merged 1 commit into from
Sep 6, 2020

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Sep 5, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38009
License MIT
Doc PR -

fabpot
fabpot approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged in master as this is a new feature. I did not register it as it was not used. But if we have the profiler's integration in 5.2, that makes sense to register it now.

@fabpot
Copy link
Member

fabpot commented Sep 5, 2020

Can you rebase on master?

@jschaedl jschaedl force-pushed the notifier-register-data-collector branch from 371b20e to 1beffd1 Compare September 6, 2020 09:12
@jschaedl jschaedl changed the base branch from 5.1 to master September 6, 2020 09:13
@jschaedl jschaedl changed the title [Notifier] Register NotificationDataCollector service [Notifier] Register NotificationDataCollector and NotificationLoggerListener service Sep 6, 2020
@jschaedl
Copy link
Contributor Author

jschaedl commented Sep 6, 2020

Can you rebase on master?

Done

@fabpot
Copy link
Member

fabpot commented Sep 6, 2020

Thank you @jschaedl.

@fabpot fabpot merged commit f15f55c into symfony:master Sep 6, 2020
@fabpot fabpot mentioned this pull request Sep 6, 2020
Closed
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Notifier Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Notifier] DataCollector for Notifier component not available
3 participants
@jschaedl @fabpot @carsonbot