Skip to content

[Process] fix tests #38014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Process] fix tests #38014

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 31, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Aug 31, 2020
@xabbuh
Copy link
Member Author

xabbuh commented Aug 31, 2020

The deprecation triggered here leads to unserialize() called in the Deprecation class of the PhpUnitBridge emits an E_NOTICE meaning that error_get_last() being used in testThatProcessDoesNotThrowWarningDuringRun() does not receive the expected notice triggered before.

@xabbuh xabbuh marked this pull request as ready for review August 31, 2020 16:46
@nicolas-grekas
Copy link
Member

We set SYMFONY_DEPRECATIONS_HELPER=weak when running the sigchild tests, which means I'm not sure about this change (and your comment also makes me think there is something else here).

@xabbuh
Copy link
Member Author

xabbuh commented Sep 1, 2020

replaced by #38020

@xabbuh xabbuh closed this Sep 1, 2020
@xabbuh xabbuh deleted the process-tests branch September 1, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Process Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot