[DependencyInjection] Trim class & method names (fix #3644) #3646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not sounds right to me. The value is everything in the tag. I don't see why we would want to make an exception for some values. -1 |
|
It's not about trimming a parameter, but the value accepted by Definition as class name or method name.
The YAML parameters are trimmed when they are not quoted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class and method names needs to be trimmed in some cases, see #3644.
Bug fix: no
Feature addition: no
Backwards compatibility break: yes
Symfony2 tests pass: yes (DIC)
Fixes the following tickets: #3644