[Notifier][Slack] Error trown when having more than 10 fields specified #36346 #36347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkof
changed the title
fabpot
requested changes
Apr 5, 2020
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackSectionBlock.php
Outdated
Show resolved
Hide resolved
|
@birkof Have you seen my comment? Do you agree? |
birkof
force-pushed
the
notifier/limitSlackSectionFields
branch
from
f898a1c to
2ea2b64
Compare
fabpot
approved these changes
Jun 25, 2020
fabpot
force-pushed
the
notifier/limitSlackSectionFields
branch
from
2ea2b64 to
68b2490
Compare
|
Thank you @birkof. |
| @@ -44,6 +44,11 @@ public function field(string $text, bool $markdown = true): self | |||
| 'text' => $text, | |||
| ]; | |||
|
|
|||
| // Maximum number of items is 10 | |||
| if (10 <= \count($this->options['fields'])) { | |||
There was a problem hiding this comment.
should be <, with <= you throw not only for count > 10 but also for count == 10
There was a problem hiding this comment.
@guilliamxavier you're right! I have tested more over here and you're right!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written in docs of Section block, for fields we have to had maximum 10 items specified.