Skip to content

[Serializer] Allow to include the severity in ConstraintViolationList #35545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Component/Serializer/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ CHANGELOG
* added support for scalar values denormalization
* added support for `\stdClass` to `ObjectNormalizer`
* added the ability to ignore properties using metadata (e.g. `@Symfony\Component\Serializer\Annotation\Ignore`)
* added an option to serialize constraint violations payloads (e.g. severity)

5.0.0
-----
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class ConstraintViolationListNormalizer implements NormalizerInterface, Cacheabl
const STATUS = 'status';
const TITLE = 'title';
const TYPE = 'type';
const PAYLOAD_FIELDS = 'payload_fields';

private $defaultContext;
private $nameConverter;
Expand All @@ -43,6 +44,18 @@ public function __construct($defaultContext = [], NameConverterInterface $nameCo
*/
public function normalize($object, string $format = null, array $context = [])
{
if (\array_key_exists(self::PAYLOAD_FIELDS, $context)) {
$payloadFieldsToSerialize = $context[self::PAYLOAD_FIELDS];
} elseif (\array_key_exists(self::PAYLOAD_FIELDS, $this->defaultContext)) {
$payloadFieldsToSerialize = $this->defaultContext[self::PAYLOAD_FIELDS];
} else {
$payloadFieldsToSerialize = [];
}

if (\is_array($payloadFieldsToSerialize) && [] !== $payloadFieldsToSerialize) {
$payloadFieldsToSerialize = array_flip($payloadFieldsToSerialize);
}

$violations = [];
$messages = [];
foreach ($object as $violation) {
Expand All @@ -57,6 +70,17 @@ public function normalize($object, string $format = null, array $context = [])
$violationEntry['type'] = sprintf('urn:uuid:%s', $code);
}

$constraint = $violation->getConstraint();
if (
[] !== $payloadFieldsToSerialize &&
$constraint &&
$constraint->payload &&
// If some or all payload fields are whitelisted, add them
$payloadFields = null === $payloadFieldsToSerialize || true === $payloadFieldsToSerialize ? $constraint->payload : array_intersect_key($constraint->payload, $payloadFieldsToSerialize)
) {
$violationEntry['payload'] = $payloadFields;
}

$violations[] = $violationEntry;

$prefix = $propertyPath ? sprintf('%s: ', $propertyPath) : '';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use PHPUnit\Framework\TestCase;
use Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter;
use Symfony\Component\Serializer\Normalizer\ConstraintViolationListNormalizer;
use Symfony\Component\Validator\Constraints\NotNull;
use Symfony\Component\Validator\ConstraintViolation;
use Symfony\Component\Validator\ConstraintViolationList;

Expand Down Expand Up @@ -106,4 +107,32 @@ public function testNormalizeWithNameConverter()

$this->assertEquals($expected, $normalizer->normalize($list));
}

/**
* @dataProvider payloadFieldsProvider
*/
public function testNormalizePayloadFields($fields, array $expected = null)
{
$constraint = new NotNull();
$constraint->payload = ['severity' => 'warning', 'anotherField2' => 'aValue'];
$list = new ConstraintViolationList([
new ConstraintViolation('a', 'b', [], 'c', 'd', 'e', null, null, $constraint),
]);

$violation = $this->normalizer->normalize($list, null, [ConstraintViolationListNormalizer::PAYLOAD_FIELDS => $fields])['violations'][0];
if ([] === $fields) {
$this->assertArrayNotHasKey('payload', $violation);

return;
}
$this->assertSame($expected, $violation['payload']);
}

public function payloadFieldsProvider(): iterable
{
yield [['severity', 'anotherField1'], ['severity' => 'warning']];
yield [null, ['severity' => 'warning', 'anotherField2' => 'aValue']];
yield [true, ['severity' => 'warning', 'anotherField2' => 'aValue']];
yield [[]];
}
}