[Serializer] add array cache in front of serializer cache #35079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ab -n 100 |
src/Symfony/Component/Serializer/Mapping/Factory/CacheClassMetadataFactory.php
Outdated
Show resolved
Hide resolved
bastnic
force-pushed
the
feature/35041-cache-CacheClassMetadataFactory2
branch
from
519d26e to
6ee306b
Compare
nicolas-grekas
approved these changes
Dec 22, 2019
|
Should we implement the |
I'm not sure this would qualify as a leak: the memory requirement is asymptotic, ie it won't grow once all classes used by the app have been loaded. This is the same for eg opcache. |
teohhanhui
reviewed
Dec 23, 2019
| @@ -32,6 +32,8 @@ class CacheClassMetadataFactory implements ClassMetadataFactoryInterface | |||
| */ | |||
| private $cacheItemPool; | |||
|
|
|||
| private $loadedClasses = []; | |||
There was a problem hiding this comment.
The name is misleading. It's actually an array of ClassMetadata.
There was a problem hiding this comment.
I followed the name of the delegated class https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Serializer/Mapping/Factory/ClassMetadataFactory.php#L31
xabbuh
approved these changes
Dec 23, 2019
nicolas-grekas
changed the title
|
Thank you @bastnic. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 26, 2019
…e (bastnic) This PR was merged into the 5.1-dev branch. Discussion ---------- [Serializer] add array cache in front of serializer cache | Q | A | ------------- | --- | Branch? | master | Bug fix? | performance | New feature? | ... | Deprecations? | no | Tickets | #35041 | License | MIT | Doc PR | This is another implementation of #35041, after #35046. The DI solution is cleaner, but 10ms slower on my scenario (13 vs 3) and this data is not supposed to change at all (even in the original method there is a local cache). Diff from master (without warmup):  Diff form master (with warmup):  Diff from #35046:  Ping @nicolas-grekas Commits ------- 6ee306b [Cache] add array cache in front of serializer cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another implementation of #35041, after #35046.
The DI solution is cleaner, but 10ms slower on my scenario (13 vs 3) and this data is not supposed to change at all (even in the original method there is a local cache).
Diff from master (without warmup):
Diff form master (with warmup):
Diff from #35046:
Ping @nicolas-grekas