-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Security] deprecate non UserInterface users #34909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this cause deprecations on anonymous authentications? The AnonymousToken also calls
setUser()
. As proposed back in #3697, perhaps an AnonymousUser would make sense? This could be a stale object always returning the same information.symfony/src/Symfony/Component/Security/Core/Authentication/Token/AnonymousToken.php
Line 33 in e60a876
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for me pushed code should just be the starting point. Actually, I was a bit surprised that our code did not trigger any deprecations. Might be an indicator that we do miss some tests (the anonymous user is one of the examples where I did expect the new deprecation to be triggered).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my proposal applied to
ControllerTrait::getUser()
, to keep it consistent withSecurity::getUser()
.no need to patch
TokenInterface
IMHO, as it's low-level API, unless we decide to refactor everything now..? 😂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is good to make the usage consistent for now. At a later stage, I hope we can get rid of the UserInterface inside the token altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ro0NL IMO it would be too confusing if the controller method behaved differently than the token storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it's confusing for
Security::getUser
to behave different already.They way i see it is,
Security/ControllerTrait::getUser()
is high-level API, designed aroundUserInterface|null
.Whereas
TokenInterface::getUser()
, the low-level API, is designed aroundobject|string|null
.So the high level API is a subset.