[Validator] add notice in UPGRADE file for new Range constraint option #33880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lctrs
approved these changes
Oct 7, 2019
nicolas-grekas
approved these changes
Oct 7, 2019
|
Thank you @dmaicher. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 7, 2019
…straint option (dmaicher) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] add notice in UPGRADE file for new Range constraint option | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #33700 | License | MIT | Doc PR | - There is a change in behavior as mentioned in #33700 that causes small issues on one of my apps. I only noticed it because of a test fail. Instead of reverting this nice feature I propose to document it in the UPGRADE file so that people are aware of it. Commits ------- d4ab35c [Validator] add notice in UPGRADE file for new Range constraint option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a change in behavior as mentioned in #33700 that causes small issues on one of my apps. I only noticed it because of a test fail.
Instead of reverting this nice feature I propose to document it in the UPGRADE file so that people are aware of it.