Drop Debug compatibility layers #33027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Aug 7, 2019
chalasr
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
chalasr
force-pushed
the
drop-debug-compat
branch
from
c73262f to
7fc93e9
Compare
yceruto
approved these changes
Aug 7, 2019
seriquynh
approved these changes
Aug 8, 2019
|
composer.json needs to be updated too, to remove the classmap entry |
|
@chalasr Line 137 in Console Application.php -> |
chalasr
force-pushed
the
drop-debug-compat
branch
from
7fc93e9 to
db0d29f
Compare
|
@fancyweb fixed, thank you. @nicolas-grekas if you mean the one added by #32873 (comment), it was reverted there |
chalasr
force-pushed
the
drop-debug-compat
branch
from
db0d29f to
6b1b05e
Compare
|
Removed the |
src/Symfony/Bridge/ProxyManager/Legacy/ProxiedMethodReturnExpression.php
Outdated
Show resolved
Hide resolved
chalasr
force-pushed
the
drop-debug-compat
branch
from
6b1b05e to
8e9bff5
Compare
| @@ -134,7 +132,7 @@ public function run(InputInterface $input = null, OutputInterface $output = null | |||
| }; | |||
| if ($phpHandler = set_exception_handler($renderException)) { | |||
| restore_exception_handler(); | |||
| if (!\is_array($phpHandler) || (!$phpHandler[0] instanceof ErrorHandler && !$phpHandler[0] instanceof LegacyErrorHandler)) { | |||
| if (!\is_array($phpHandler) || (!$phpHandler[0] instanceof ErrorHandler)) { | |||
There was a problem hiding this comment.
extra brackets should be removed :)
chalasr
force-pushed
the
drop-debug-compat
branch
from
8e9bff5 to
2326b80
Compare
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Drop Debug compatibility layers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 2326b80 [Debug] Drop compatibility layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.