Skip to content

Support for specific user instances to be resolved #32407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support for specific user instances to be resolved #32407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Symfony/Component/Security/Http/Controller/UserValueResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ public function __construct(TokenStorageInterface $tokenStorage)

public function supports(Request $request, ArgumentMetadata $argument)
{
$type = $argument->getType();
// only security user implementations are supported
if (UserInterface::class !== $argument->getType()) {
if (UserInterface::class !== $type && !is_subclass_of($type, UserInterface::class)) {
return false;
}

Expand All @@ -47,7 +48,11 @@ public function supports(Request $request, ArgumentMetadata $argument)
$user = $token->getUser();

// in case it's not an object we cannot do anything with it; E.g. "anon."
return $user instanceof UserInterface;
if (!$user instanceof UserInterface){
return false;
}

return $user instanceof $type;
}

public function resolve(Request $request, ArgumentMetadata $argument)
Expand Down