-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[DI] highlight suspicious tests #31942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -332,6 +332,7 @@ class EnvConfigurationWithoutRootNode implements ConfigurationInterface | |
{ | ||
public function getConfigTreeBuilder() | ||
{ | ||
throw new \Exception(); | ||
return new TreeBuilder('env_extension'); | ||
} | ||
} | ||
|
@@ -340,6 +341,7 @@ class ConfigurationWithArrayNodeRequiringOneElement implements ConfigurationInte | |
{ | ||
public function getConfigTreeBuilder() | ||
{ | ||
throw new \Exception(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the test ensures we dont require a node to be present, if the user didnt configure anything. However the side effect is the config tree isnt even initialized ... so it doesnt matter much what happens here. I'd keep this tree for the purpose of clarity, in the sense we don't expect an |
||
$treeBuilder = new TreeBuilder('env_extension'); | ||
$treeBuilder->getRootNode() | ||
->children() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test from #27472 is actually invalidated due #27710, we should pass some config to ensure the treebuilder is called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up for a PR?