Skip to content

[DI] highlight suspicious tests #31942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[DI] highlight suspicious tests #31942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Component/DependencyInjection/Tests/Compiler/ValidateEnvPlaceholdersPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ class EnvConfigurationWithoutRootNode implements ConfigurationInterface
{
public function getConfigTreeBuilder()
{
throw new \Exception();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test from #27472 is actually invalidated due #27710, we should pass some config to ensure the treebuilder is called

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up for a PR?

return new TreeBuilder('env_extension');
}
}
Expand All @@ -340,6 +341,7 @@ class ConfigurationWithArrayNodeRequiringOneElement implements ConfigurationInte
{
public function getConfigTreeBuilder()
{
throw new \Exception();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test ensures we dont require a node to be present, if the user didnt configure anything. However the side effect is the config tree isnt even initialized ... so it doesnt matter much what happens here.

I'd keep this tree for the purpose of clarity, in the sense we don't expect an InvalidConfigException due nodes being required.

$treeBuilder = new TreeBuilder('env_extension');
$treeBuilder->getRootNode()
->children()
Expand Down