[DX][Messenger] Improve error message when routing to an invalid transport #31710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
DX
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
Koc
force-pushed
the
better-error-on-invalid-routing
branch
from
c0e8cd5 to
7e50aff
Compare
|
BTW, does anybody knows why Travis failed with error ? Is this problem caused by Symfony Flex or what? |
|
@Koc I think you just need to repush |
Koc
force-pushed
the
better-error-on-invalid-routing
branch
2 times, most recently
from
470e6d5 to
464f326
Compare
Koc
force-pushed
the
better-error-on-invalid-routing
branch
from
464f326 to
94a404f
Compare
|
@Koc any chance you can rebase on |
|
@Koc could you rebase please ? |
Koc
force-pushed
the
better-error-on-invalid-routing
branch
from
040aa8c to
0e78098
Compare
|
Rebase was done, now trying to fix tests |
|
(rebase needed) |
Koc
force-pushed
the
better-error-on-invalid-routing
branch
from
bdc8896 to
ff33f61
Compare
Koc
force-pushed
the
better-error-on-invalid-routing
branch
from
9342d65 to
7909092
Compare
|
rebased, tests are green |
fabpot
approved these changes
Sep 28, 2019
|
Thank you @Koc. |
fabpot
added a commit
that referenced
this pull request
Sep 28, 2019
… invalid transport (Koc) This PR was merged into the 4.4 branch. Discussion ---------- [DX][Messenger] Improve error message when routing to an invalid transport | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31613 | License | MIT | Doc PR | - Commits ------- 7909092 [Messenger] Improve error message when routing to an invalid transport (closes #31613)
ro0NL
reviewed
Sep 28, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.