[WebProfilerBundle][DX] Where are the deprecation messages coming from? #31015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
WebProfilerBundle
DX
nicolas-grekas
changed the title
|
Tests need to be updated. |
| @@ -27,7 +27,7 @@ class TreeBuilder implements NodeParentInterface | |||
| public function __construct(string $name = null, string $type = 'array', NodeBuilder $builder = null) | |||
| { | |||
| if (null === $name) { | |||
| @trigger_error('A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.', E_USER_DEPRECATED); | |||
| @trigger_error(sprintf('A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0 see %s.', end(explode('/', debug_backtrace()[0]['file']))), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
using basename() could fix the failing test think
|
I tested this PR. The result looks like this:
Im not sure it is super helpful to see "Configuration.php" in the deprecation warning. |
|
Yeah it’s not enough to deaggregzte them, maybe like nicolas said using
basename would be better.
Le lun. 8 avr. 2019 à 23:58, Tobias Nyholm <notifications@github.com> a
écrit :
… I tested this PR. The result looks like this:
[image: Screenshot 2019-04-08 at 23 55 54]
<https://user-images.githubusercontent.com/1275206/55759576-f6c1dc80-5a59-11e9-9739-4e6bcfe6f329.png>
Im not sure it is super helpful to see "Configuration.php" in the
deprecation warning.
Im more helped by the trace.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31015 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADSq8mcgFa1CZ6dR58omqfFubMhnoNRJks5ve7ttgaJpZM4cinbW>
.
|
|
I think #31027 is a better alternative. WDYT? |
|
I agree, thanks for giving it a try! |
Simperfit
deleted the
feature/add-more-context-to-the-deprecation-message
branch
fabpot
added a commit
that referenced
this pull request
Apr 9, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Config] Deprecate TreeBuilder::root | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | | Fixed tickets | #29876 | License | MIT | Doc PR | — Alternative idea to #31015. Or is the `root` method still needed? It would look like this:  Commits ------- ff6bc79 Deprecate TreeBuilder::root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test according to this deprecation has been updated accordingly, it seems to be enough to limit the aggregation of message coming from different bundles