Skip to content

[Intl] fixed tests by providing nullable type hints instead of strict ones #29785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Stas-Soroka
Copy link
Contributor

Q A
Branch? master
Bug fix? no (test fix)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT

Currently tests IntlDateFormatterTest::testConstructorWithoutDateType and IntlDateFormatterTest::testConstructorWithoutTimeType are not passing because of strict type hints for datetype and timetpye parameters in IntlDateFormatter class contructor, whereas PHPDoc hints that these parameters are nullable. This PR resolves it, and makes all tests in the Intl test suite pass.

@Stas-Soroka Stas-Soroka closed this Jan 5, 2019
@Stas-Soroka Stas-Soroka deleted the fix_tests_by_imporving_typehints branch January 5, 2019 05:09
@Stas-Soroka
Copy link
Contributor Author

Unintentional duplicate of #29782 (whoopsie)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants