[Cache] fix bad optim #29644
Merged
[Cache] fix bad optim #29644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 18, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29643 |
| License | MIT |
| Doc PR | - |
|
@nicolas-grekas out of curiosity, could you provide a description why it fixes the thing? |
|
@seclu see what @strider2038 provided in the linked issue #29643. |
theofidry
reviewed
Dec 18, 2018
|
|
||
| $e = new \Exception(); | ||
| $this->includeHandler = function () use ($e) { throw $e; }; | ||
| $this->includeHandler = function ($type, $msg, $file, $line) { |
There was a problem hiding this comment.
shouldn't this be a static function?
There was a problem hiding this comment.
it would be a public one - better not (and would be slower if that matters)
There was a problem hiding this comment.
I meant a static anonymous function, i.e just adding static in front of the current function keyword, not moving it to a static method. It doesn't affect the visibility does it?
stof
reviewed
Dec 18, 2018
|
@seclu it does not create an exception with its stack trace in the constructor anymore. the stack trace was the one retaining references to other stuff. |
nicolas-grekas
force-pushed
the
cache-fix
branch
from
39cffee to
b76d4ea
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 19, 2018
This PR was merged into the 4.2 branch. Discussion ---------- [Cache] fix bad optim | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29643 | License | MIT | Doc PR | - Commits ------- b76d4ea [Cache] fix bad optim
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.