-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Messenger] Restore message handlers laziness #29558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0acdfd6
to
879d73e
Compare
nicolas-grekas
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(SendersLocator is fine?)
ogizanagi
approved these changes
Dec 11, 2018
88ef942
to
1d7455b
Compare
@nicolas-grekas it looked fine, but updated for consistency and simplicity. |
1d7455b
to
c608e73
Compare
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
This PR was merged into the 4.2 branch. Discussion ---------- [Messenger] Restore message handlers laziness | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The `HandlersLocator` introduced in 4.2 currently needs to instantiate all message handlers of the bus in order to be wired, while they were lazily loaded in 4.1 via ContainerHandlerLocator (removed). Example: ```yaml framework: messenger: buses: messenger.bus.command: ~ services: App\Messenger\: resource: '../src/Messenger/*Handler.php' tags: - { name: messenger.message_handler, bus: messenger.bus.command } ``` ```php namespace App\Messenger; class BarCommand {} class BarCommandHandler { public function __invoke(BarCommand $command): void {} } class FooCommand {} class FooCommandHandler { public function __invoke(FooCommand $command): void {} } ``` (Dumped `HandleMessageMiddleware` factory) Before: ```php return $this->privates['messenger.bus.command.middleware.handle_message'] = new \Symfony\Component\Messenger\Middleware\HandleMessageMiddleware(new \Symfony\Component\Messenger\Handler\HandlersLocator(array( 'App\\Messenger\\BarCommand' => \current(array(0 => array(0 => new \App\Messenger\BarCommandHandler()))), 'App\\Messenger\\FooCommand' => \current(array(0 => array(0 => new \App\Messenger\FooCommandHandler()))) ))); ``` After: ```php return $this->privates['messenger.bus.command.middleware.handle_message'] = new \Symfony\Component\Messenger\Middleware\HandleMessageMiddleware(new \Symfony\Component\Messenger\Handler\HandlersLocator(array( 'App\\Messenger\\BarCommand' => new RewindableGenerator(function () { yield 0 => ($this->privates['App\Messenger\BarCommandHandler'] ?? ($this->privates['App\Messenger\BarCommandHandler'] = new \App\Messenger\BarCommandHandler())); }, 1), 'App\\Messenger\\FooCommand' => new RewindableGenerator(function () { yield 0 => ($this->privates['App\Messenger\FooCommandHandler'] ?? ($this->privates['App\Messenger\FooCommandHandler'] = new \App\Messenger\FooCommandHandler())); }, 1) ))); ``` Commits ------- c608e73 [Messenger] Restore message handlers laziness
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HandlersLocator
introduced in 4.2 currently needs to instantiate all message handlers of the bus in order to be wired, while they were lazily loaded in 4.1 via ContainerHandlerLocator (removed).Example:
(Dumped
HandleMessageMiddleware
factory) Before:After: