Skip to content

Allow autowire of HttpUtils #27547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow autowire of HttpUtils #27547

wants to merge 1 commit into from

Conversation

XWB
Copy link
Contributor

@XWB XWB commented Jun 7, 2018

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Autowiring the security util throws a deprecation notice and won't work anymore in Symfony 4.

Autowiring services based on the types they implement is deprecated since Symfony 3.3 and won't be supported in version 4.0. You should rename (or alias) the "security.http_utils" service to "Symfony\Component\Security\Http\HttpUtils" instead.

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 7, 2018
@XWB XWB changed the base branch from master to 3.4 June 7, 2018 21:58
@XWB
Copy link
Contributor Author

XWB commented Jun 7, 2018

One of the tests has timed out. Please restart.

@XWB
Copy link
Contributor Author

XWB commented Jun 7, 2018

@nicolas-grekas Apologies, PR has been updated as the base branch should be 3.4, so the milestone tag should be changed as well.

@chalasr
Copy link
Member

chalasr commented Jun 7, 2018

The alias has been added by #25562 which has merged as a new feature for 4.1.
On 3.4 you can add the alias on your side, not worth backporting to me. -1

@fabpot
Copy link
Member

fabpot commented Jun 8, 2018

Closing as we don't add new features in older branches. As mentioned by @chalasr, it's already part of 4.1 anyway. Thanks for your pull request.

@fabpot fabpot closed this Jun 8, 2018
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants