[WebProfilerBundle] Handle 'unsafe-eval' in CSP #27521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In base_js_html.twig eval is used but the ContentSecurityPolicyHandler never adds 'unsafe-eval' to the nonce which breaks the profiler with very strict CSPs
|
Please avoid reducing the indentation by 1 space here. It makes the diff impossible to review. We use 4 spaces per indentation level |
|
and btw, bug fixes are not allowed in 3.2 anymore. This branch is not maintained: http://symfony.com/roadmap/3.2 |
|
sorry for that. I created #27525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In base_js_html.twig eval is used but the ContentSecurityPolicyHandler never adds 'unsafe-eval' to the nonce which breaks the profiler with very strict CSPs
I was using the profiler bundle with the very strict CSP "default-src 'self'; script-src 'self';" and the browser was not loading the toolbar because of CSP violations.
I honestly don't know if this is the best way to fix them / handle unsafe-eval, but this is working fone for me and maybe @romainneutron can help me out